[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3439) Change o.h.cfg.Mappings to not require constructor

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_30939 ] 

Emmanuel Bernard commented on HHH-3439:
---------------------------------------

I have been thinking though that a bit. I think you still need a way to override how Mapping (or its subclasses) are instantiated:
Annotations needs ExtendedMappings, Core needs Mapping
Somehow the Mapping object initialization can be shared. Core can init its bits and annotation initialize its bits.

It's more a constructor issue than an interface issue, we are facing now.

> Change o.h.cfg.Mappings to not require constructor
> --------------------------------------------------
>
>                 Key: HHH-3439
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3439
>             Project: Hibernate3
>          Issue Type: Improvement
>          Components: metamodel
>            Reporter: Steve Ebersole
>            Assignee: Steve Ebersole
>             Fix For: 3.4
>
>
> Mappings requiring passing all the mapping queues into its constructor causes interoperability issues with other components (annotations e.g.) because they generally extend Mappings to add extra information.  Therefore we introduce an incompatibility whenever we add a new mapping attribute because we are currently forced to change the signature of the Mappings constructor.
> A better approach is to make Mappings an interface with an impl that defined as an inner class to o.h.cfg.Configuration so that it can expose access to the queues directly from there.  Annotations, etc can than simply extend that Mappings impl. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira