[hibernate-issues] [Hibernate-JIRA] Updated: (HHH-3084) DialectFactory.java doesn't map the IngresDialect

[Emmanuel Bernard (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Bernard updated HHH-3084:
----------------------------------

    Affects Version/s:     (was: 3.2.4.sp1)
                           (was: 3.2.4)
                           (was: 3.2.3)
                           (was: 3.2.0.cr5)
                           (was: 3.2.0.ga)
                           (was: 3.2.2)
                           (was: 3.2.0.cr4)
                           (was: 3.2.0.cr3)
                           (was: 3.2.1)
                           (was: 3.2.0.cr2)
                           (was: 3.2.0 cr1)
                           (was: 3.2.0.alpha2)
                           (was: 3.1.3)
                           (was: 3.1)
                           (was: 3.1.2)
                           (was: 3.1.1)
                           (was: 3.2.0.alpha1)
                           (was: 3.1 rc2)
                           (was: 3.1 rc 1)
                           (was: 3.1 beta 2)
                           (was: 3.1 beta 1)
                           (was: 3.0.5)
                           (was: 3.0.4)
                           (was: 3.0.3)
                           (was: 3.0.2)
                           (was: 3.0.1)
                           (was: 3.0 final)
                           (was: 3.0 rc 1)
                           (was: 3.0 beta 4)
                           (was: 3.0 beta 3)
                           (was: 3.0 beta 2)
                           (was: 3.1 rc3)
                           (was: 3.0 beta 1)
                           (was: 3.0 alpha)
        Fix Version/s: 3.3
                       3.2.6
           Issue Type: Improvement  (was: Bug)

Steve I put 3.2.6 just in case, feel free to delay

> DialectFactory.java doesn't map the IngresDialect
> -------------------------------------------------
>
>                 Key: HHH-3084
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3084
>             Project: Hibernate3
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.2.5
>         Environment: Hibernate 3.x and frameworks based on the Spring Framework, like Grails
>            Reporter: Michael Leo
>             Fix For: 3.2.6, 3.3
>
>         Attachments: DialectFactory.java.patch
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> Although Hibernate ships with an Ingres dialect 
>     org.hibernate.dialect.IngresDialect
>  it can't be found by the dialect factory
>     org.hibernate.dialect.DialectFactory
> Although most tools can be forced to use the proper dialect, there is a circumstance
> in Grails where there is no way to specify the correct Hibernate dialect for a custom 
> data source.
> The patch is pretty straightforward.  I've attached the output of "svn diff" from the 
> root of the latest branch.
> Hope this makes sense,
> Mike Leo
> $ svn diff
> Index: src/org/hibernate/dialect/DialectFactory.java
> ===================================================================
> --- src/org/hibernate/dialect/DialectFactory.java       (revision 14289)
> +++ src/org/hibernate/dialect/DialectFactory.java       (working copy)
> @@ -112,6 +112,9 @@
>         private static final Map MAPPERS = new HashMap();
>         static {
>                 // TODO : this is the stuff it'd be nice to move to a properties file or some other easily user-editable place
> +               MAPPERS.put( "Ingres", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
> +               MAPPERS.put( "ingres", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
> +               MAPPERS.put( "INGRES", new VersionInsensitiveMapper( "org.hibernate.dialect.IngresDialect" ) );
>                 MAPPERS.put( "HSQL Database Engine", new VersionInsensitiveMapper( "org.hibernate.dialect.HSQLDialect" ) );
>                 MAPPERS.put( "DB2/NT", new VersionInsensitiveMapper( "org.hibernate.dialect.DB2Dialect" ) );
>                 MAPPERS.put( "DB2/LINUX", new VersionInsensitiveMapper( "org.hibernate.dialect.DB2Dialect" ) );
> $

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira