[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2021) org.hibernate.cache.QueryKey has a fragile equals() method

[Suzanne Weller (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_29685 ] 

Suzanne Weller commented on HHH-2021:
-------------------------------------

This is causing the same problem for my custom cache implementation which holds both entities and queries in the same underlying map.  It seems like a quick fix and an unnecessary assumption that a QueryKey will never be used in a map which also contains keys with different types.

> org.hibernate.cache.QueryKey has a fragile equals() method
> ----------------------------------------------------------
>
>                 Key: HHH-2021
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2021
>             Project: Hibernate3
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.1.3
>            Reporter: Kenny MacLeod
>            Priority: Trivial
>
> This one is no great shakes, but the first line of QueryKey.equals() casts the argument to QueryKey without checking for its type.  As such, the method is fragile.
> It should be consistent with CacheKey, which does an instanceof check before the cast.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira