[hibernate-issues] [Hibernate-JIRA] Updated: (HSEARCH-153) Provide the possibility to configure writer.setRAMBufferSizeMB() (Lucene 2.3)

[Sanne Grinovero (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanne Grinovero updated HSEARCH-153:
------------------------------------

    Attachment: patch.txt

Hi,

this includes the new feature, a trivial test case and some documentation updates.
Also some refactoring has been done, so to make management of other parameters easier.

I couldn't write a test case verifying that the parameters are actually set on the indexwriter, as I didn't manage to get visibility on the indexwriter; so tests just verify the options are picked up and don't break previous behavior.

I think the "default values" management got simplified, it is no longer needed to have a copy of the values from lucene, it just skips the setter on undefined values.

The "DEFAULT_MAX_BUFFERED_DOCS" is still set to 10, as it is different than the lucene defaults; I think it could be a bug and would be tempted to remove it, but will leave that decision to Emmanuel or Hardy;
The lucene default is "not set it", so to use only RamBuffer as flush control limit.

Also, it would be nice to have the option to put "null" in the configuration, to explicitly set options to "lucene default",
without having to know them; Currently settings are inherited from "default" directoryprovider if any, and "batch" settings inherit from "transaction", so I think it could be useful explicitly setting some value to null.

> Provide the possibility to configure writer.setRAMBufferSizeMB()  (Lucene 2.3)
> ------------------------------------------------------------------------------
>
>                 Key: HSEARCH-153
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-153
>             Project: Hibernate Search
>          Issue Type: New Feature
>          Components: engine
>            Reporter: Emmanuel Bernard
>         Attachments: patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira