[hibernate-issues] [Hibernate-JIRA] Updated: (HSEARCH-133) Allow overiding DefaultSimilarity for indexing and searching (Nick Vincent)

[Emmanuel Bernard (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Bernard updated HSEARCH-133:
-------------------------------------

    Affects Version/s:     (was: 3.0.1.GA)
        Fix Version/s: 3.1.0
              Summary: Allow overiding DefaultSimilarity for indexing and searching (Nick Vincent)  (was: Allow ovrriding DefaultSimilarity for indexing and searching)

Committed but there are still some questions.
The patch looked good as is aside from style issues. I have added a hibernate.search.similarity property to set a global similarity

Questions:
 - if there are multiple similarities defined on a class hierarchy, should we throw an exception?
technically, each subclass can be in its own DirectoryProvider but polymorphic queries do query the whole hieirachy (and DPs)
  I guess the answer should be exception but I'd like feedback

 - if there are multiple similarities defined on a class graph (@IndexedEmbedded), should we throw an exception? should we only use the main class similarity?




> Allow overiding DefaultSimilarity for indexing and searching (Nick Vincent)
> ---------------------------------------------------------------------------
>
>                 Key: HSEARCH-133
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-133
>             Project: Hibernate Search
>          Issue Type: New Feature
>          Components: engine, query
>            Reporter: John Griffin
>            Assignee: John Griffin
>             Fix For: 3.1.0
>
>         Attachments: similarity.diff, similaritypatch.txt
>
>
> Ability to override DefaultSimilarity for indexing and searching should be implemented. Access is necessary in both places because changing only one and then querying has undefined results as far as scores are concerned.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira