[hibernate-issues] [Hibernate-JIRA] Commented: (HBX-1042) Make DocHelper robust against failing buildSettings()

[Arnout Engelen (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_30274 ] 

Arnout Engelen commented on HBX-1042:
-------------------------------------

The reason for getting the connection is to find out the default schema, default catalog and dialect.

Indeed, this information can be found in the Properties. Reading your workaround suggestion again, you're proposing to take these options from the Properties by default (and only go to the database if they cannot be found there)? Sounds reasonable to me.

> Make DocHelper robust against failing buildSettings()
> -----------------------------------------------------
>
>                 Key: HBX-1042
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1042
>             Project: Hibernate Tools
>          Issue Type: Improvement
>          Components: hbm2doc
>            Reporter: Arnout Engelen
>         Attachments: dochelper.diff.txt
>
>
> DocHelper calls cfg.buildSettings(). to get the Dialect, default catalog name and default schema name.
> However, cfg.buildSettings() may fail with a HibernateException (example below). 
> It would be nice to have DocHelper handle this more gracefully. Attached is a simple patch that does this.
> (background: I'd like to use the Configuration I'm getting from a Spring LocalSessionFactoryBean, which after initial creation leaves its LocalDataSourceConnectionProvider in a state that yiels a HibernateException when calling 'configure()' on it, which buildSettings() does. Because of this issue, I cannot use the DocExporter for my Spring-based hibernate configurations)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira