[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-246) Run optimize at the end of the transaction even if flushToIndexes() is used

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31771#action_31771 ] 

Sanne Grinovero commented on HSEARCH-246:
-----------------------------------------

he well... we agree now but it's getting worse.
I think we need to break our current backend API:

public Runnable getProcessor(List<LuceneWork> queue);

the backend only gets the list, we need some way to tell the backend this is not a commit but
a "flushToIndexes". This is something that could be usefull anyway.

What about something like
"public Runnable getProcessor(WorkQueue queue);"
making a transport object? so next time we need something we can just add methods or fields to it.
I think this would break serializable compatibility, especially for JMS backend.

Maybe we should support a new method in addition to the original:
"public Runnable getProcessor(WorkQueue queue, boolean commit);"
this could be useful to really share the indexwriter, enabling the <batch mode> as I meant it on the dev list:
the IndexWriter is not released, but waits for next load of work, until a commit==true
which will eventually trigger automatic optimization, really flush the IndexWriter and release it.
Of course the old method would map to the new one defaulting to commit=true.


> Run optimize at the end of the transaction even if flushToIndexes() is used
> ---------------------------------------------------------------------------
>
>                 Key: HSEARCH-246
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-246
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: optimizer
>            Reporter: Emmanuel Bernard
>             Fix For: 3.1.0
>
>
> I am not sure if it's easily feasible but it should be the case. I am mentioning as the feature in the book for now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira