[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-309) PurgeAllLuceneWork duplicates in work queue

[Hardy Ferentschik (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31824#action_31824 ] 

Hardy Ferentschik commented on HSEARCH-309:
-------------------------------------------

After I removed the usage in FullTextSessionImpl it seems there is only one usage left and that's in MultiClassesQueryLoader. I believe the 'subclasses' field was initially created for this class and its usage within. I think the easiest would be to rename it - 'classAndSubclasses'. Maybe even more importantly we should then rename the getter in the builder to getMappedClassAndSubclasses(). Even though that might be understood the wrong way as well. WDYT?

> PurgeAllLuceneWork duplicates in work queue
> -------------------------------------------
>
>                 Key: HSEARCH-309
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-309
>             Project: Hibernate Search
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 3.1.0.CR1
>            Reporter: Sanne Grinovero
>            Assignee: Hardy Ferentschik
>             Fix For: 3.1.0
>
>
> when using purgeAll( typeA ); you get two works to purge typeA in the queue, +1 for each subclass.
> The problem is caused by the presence of each type in the set of it's subtypes in DocumentBuilderContainedEntity.subclasses 
> I tried having the typeA removed from the subclasses set, but this breaks many other features (junit told).
> It appears some other code is relying on the fact that this set has to contain the super class too; this looks strange?
> so the easy fix would be to change the current purgeAll() to not purge on the root entity too, as doing it on subclasses is enough;
> but it actually feels to me this is the only correct method, and we should check other usages.
> I've seen this affect only purgeAll but could be more critical, so priority must be investigated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira