[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2933) externalize automatic resolution of Dialect (Tomoto Shimizu Washio)

[Steve Ebersole (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31372#action_31372 ] 

Steve Ebersole commented on HHH-2933:
-------------------------------------

DatabaseMetaData has a method getConnection() so personally I think its '6 in one, half dozen in the other'.  But I think having DatabaseMetaData as the param type conveys the intent more clearly, so lets go with that.

With regards to SQLException, what I mean is that given druthers I would only allow java.sql.SQLNonTransientConnectionException
 if we were using Java 6.  But of course that is not the case.  As it is, allowing throwing of the generic SQLException does not convey the intent.  Sadly I'd have to say that imo most developers would not even check the javadocs here; they'd just see 'SQLException' allowed in the throws clause and not handle it at all.  

> externalize automatic resolution of Dialect (Tomoto Shimizu Washio)
> -------------------------------------------------------------------
>
>                 Key: HHH-2933
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933
>             Project: Hibernate Core
>          Issue Type: Patch
>          Components: core
>    Affects Versions: 3.2.5
>            Reporter: Mikael Kopteff
>            Assignee: Steve Ebersole
>             Fix For: 3.2.x, 3.3.x, 3.4
>
>         Attachments: dialect_registration.zip, dialect_registration_rev2.zip
>
>
> Introducing DialectResolver!
> Much better approach to resolving JDBC Connection information to Dialect allowing users to define custom behavior

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira