[hibernate-issues] [Hibernate-JIRA] Updated: (HHH-2933) externalize automatic resolution of Dialect (Tomoto Shimizu Washio)

[Steve Ebersole (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Ebersole updated HHH-2933:
--------------------------------

    Attachment: HHH-2293-DialectResolver-svn.patch

Tomoto, I am attaching here the code I am prepared to commit.  I wanted to give you a chance to look it over before I did so.  There are some slight changes to the patch you uploaded.  Mostly I redid the DialectResolver hierarchy.  I also changed up the tests to utilize proxies rather than straight impls of Connection/DatabaseMetaData to allow testing with JDBC3 as well as JDBC4.

Regarding the exceptions, the code here basically says that any JDBCConnectionException (SQLException indicating connection problems) causes an immediate stop to attempts to resolve the Dialect.  All other exceptions are logged as warning and resolution continues. 

> externalize automatic resolution of Dialect (Tomoto Shimizu Washio)
> -------------------------------------------------------------------
>
>                 Key: HHH-2933
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933
>             Project: Hibernate Core
>          Issue Type: Patch
>          Components: core
>    Affects Versions: 3.2.5
>            Reporter: Mikael Kopteff
>            Assignee: Steve Ebersole
>             Fix For: 3.2.x, 3.3.x, 3.4
>
>         Attachments: dialect_registration.zip, dialect_registration_rev2.zip, HHH-2293-DialectResolver-svn.patch
>
>
> Introducing DialectResolver!
> Much better approach to resolving JDBC Connection information to Dialect allowing users to define custom behavior

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira