[hibernate-issues] [Hibernate-JIRA] Commented: (HSHARDS-51) ShardResolutionStrategyImpl needs equals() and hashCode()

[Danny Antonetti (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=31202#action_31202 ] 

Danny Antonetti commented on HSHARDS-51:
----------------------------------------

That makes a lot more sense.

I have the following comment about ShardResolutionStrategyDataImpl.

If you subclass ShardResolutionStrategyDataImpl then equals could break

This is the offending line code
getClass() != o.getClass()

But this is only if you ever try to compare two different implementations of ShardResolutionStrategyData

Maybe this is a moot point, because you may not ever need more than one implementation of this class in a JVM.


> ShardResolutionStrategyImpl needs equals() and hashCode()
> ---------------------------------------------------------
>
>                 Key: HSHARDS-51
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51
>             Project: Hibernate Shards
>          Issue Type: Bug
>          Components: engine
>            Reporter: Max Ross
>            Assignee: Max Ross
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> There's basically no way to implement a cache-aware ShardResolutionStrategy until we implement equals() and hashCode() on ShardResolutionStrategyImpl.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira