[hibernate-issues] [Hibernate-JIRA] Updated: (HHH-2933) DialectFactory dialects should be in a properties file

[Tomoto Shimizu Washio (JIRA)]

     [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomoto Shimizu Washio updated HHH-2933:
---------------------------------------

    Attachment: dialect_registration_rev2.zip

Redesigned and recreated the patch.  I faced a minor issue with SQLException in DialectResolver, and I hope you would think my solution was reasonable.  Please let me know if I was doing something wrong.

> DialectFactory dialects should be in a properties file
> ------------------------------------------------------
>
>                 Key: HHH-2933
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2933
>             Project: Hibernate Core
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.2.5
>            Reporter: Mikael Kopteff
>         Attachments: dialect_registration.zip, dialect_registration_rev2.zip
>
>
> Currently the DialectFactory has the static attribute MAPPERS, that hold the dialects. If the dialect is not found, Hibernate will throw an exception. There is already an TODO tag, set for this.So, could this be possibly done, so that the values really are a) in a properties file or b)additions could be made to the map programmaticaly by users.
> This would be more flexible for advanced users, that work with experimental jdbc drivers(that don't return a standard name for the database).
> The current trunk version of DialectFactory:
> // TODO : this is the stuff it'd be nice to move to a properties file or some other easily user-editable place
> 	private static final Map MAPPERS = new HashMap();
> 	static {
> 		MAPPERS.put( "HSQL Database Engine", new VersionInsensitiveMapper( "org.hibernate.dialect.HSQLDialect" ) );
> 		MAPPERS.put( "H2", new VersionInsensitiveMapper( "org.hibernate.dialect.H2Dialect" ) );
> 		MAPPERS.put( "MySQL", new VersionInsensitiveMapper( "org.hibernate.dialect.MySQLDialect" ) );
>                 etc.....

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira