[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2971) AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs

[Thomas S (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33751#action_33751 ] 

Thomas S commented on HHH-2971:
-------------------------------

> And what is the problem of logging the exception? 
As Craig suggest you can filter out logging from AbstractFlushingEventListener but this is only treating the symptons and not fixing the problem.

In my case we have customers that buy and install out system. I can't rely on all customers not to configure or change the log filter. In case they don't filter out those messages we will have them on the phone, and maybe even accept an error report on the exception, causing everybody to waste their time.

Instead I would like Diego to explain why the log statement is needed when you rethrow the exception? Removing the log statement doesn't change the behavior of your application ;-)

> AbstractFlushingEventListener catches, logs and re-throws HibernateException in performExecutions generating noisy logs
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HHH-2971
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2971
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.2.5
>         Environment: v3.2.5
>            Reporter: craig mcmillan
>            Assignee: Diego Plentz
>            Priority: Minor
>         Attachments: tags.v325.r14204.patch
>
>
> AbstractFlushingEventListener catches HibernateException, logs an error, and re-throws the same HibernateException... so the Exception gets logged twice, or worse [ in the case i'm looking at, an offline locker ], an expected Exception [ConstraingViolationException] is caught and discarded, but an error is still logged

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira