[hibernate-issues] [Hibernate-JIRA] Commented: (ANN-572) @Node(name=, embedXml=true|false) for DOM4J

[Arturo Frappé (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/ANN-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33864#action_33864 ] 

Arturo Frappé commented on ANN-572:
-----------------------------------

¿What does javax.persistence.Embedded mean? I was wondering if Embedded annotation interfers with Node annotation in any sense.

This line is found inside org.hibernate.cfg.AnnotationBinder::processElementAnnotations( .. ) {

...
near 1544 line of code:
 //potential element
property.isAnnotationPresent( Embedded.class ) ;
...


I think that this line overrides the @Node(embedXML=true|false)  

What if the same line is rewritten:

//potential element
collectionBinder.setEmbedded( BinderHelper.isElementNodeEmbeddedXML( property ) || property.isAnnotationPresent( Embedded.class ) );

Considering that a @Node is also present and is predominant ?

What if the prescence of @Embedded annotation is ignored, what will be the effect?





> @Node(name=, embedXml=true|false) for DOM4J
> -------------------------------------------
>
>                 Key: ANN-572
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-572
>             Project: Hibernate Annotations
>          Issue Type: Improvement
>          Components: binder
>            Reporter: Emmanuel Bernard
>             Fix For: 3.5
>
>         Attachments: ANN-572-patch-by-afm.patch, hibernate-node-annotation.zip
>
>
> If there are unit tests for each then that's all good.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira