[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-4531) Derby dialect should not support comments

[Strong Liu (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35039#action_35039 ] 

Strong Liu commented on HHH-4531:
---------------------------------

community users

> Derby dialect should not support comments
> -----------------------------------------
>
>                 Key: HHH-4531
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4531
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.3.2
>         Environment: Derby 10.5.3.0, Linux
>            Reporter: Chris Wilson
>            Assignee: Strong Liu
>             Fix For: 3.3.x, 3.5
>
>
> Our mapping files contain column comments because they are supported on some of our databases. We use hbm2ddl to export the schema to each database. We are now adding support for Derby.
> Unfortunately Derby does not support column comments. I get errors like:
>   ERROR SchemaExport: Unsuccessful: comment on column building_type.description is 'Site Building Type Description'
>   ERROR SchemaExport: Syntax error: Encountered "comment" at line 1, column 1.
> I think that the DerbyDialect should return false for supportsCommentOn(). However it inherits from DB2Dialect which returns true for this property.
> Please add the following to DerbyDialect:
> 	public boolean supportsCommentOn() {
> 		return false;
> 	}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira