[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3544) Nullability.checkNullability() throws PropertyValueException (not-null property references a null property) for a property that ForeignKeys.Nullifier.nullifyTransientReferences() just nulled
Jay Paulsen (JIRA)
noreply at atlassian.com
Tue Feb 3 21:48:38 EST 2009
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32298#action_32298 ]
Jay Paulsen commented on HHH-3544:
----------------------------------
Krasimir,
I have encountered an issue that sounds very similar to this one. I've posted a question on the forum about it: http://forum.hibernate.org/viewtopic.php?t=994229.
I've verified that the patch you have provided here does indeed fix my test case. However, when I run the full suite of test cases with this patch applied I get several failures. I'm not a expert maven user by any means so I may have botched something. Have you been able to get a successful build with the patch applied?
Here is the output from the tests:
Results :
Tests in error:
testOuterJoin(org.hibernate.test.legacy.MasterDetailTest)
testCopy(org.hibernate.test.legacy.MasterDetailTest)
testOneToOneFormula(org.hibernate.test.onetoone.formula.OneToOneFormulaTest)
testOneToOneEmbeddedCompositeKey(org.hibernate.test.onetoone.formula.OneToOneFormulaTest)
testCreateQuery(org.hibernate.test.typedmanytoone.TypedManyToOneTest)
testCircularCascade(org.hibernate.test.legacy.ParentChildTest)
testLazy(org.hibernate.test.lazyonetoone.LazyOneToOneTest)
testLazyDynamicClass(org.hibernate.test.entitymode.map.basic.DynamicClassTest)
testOneToOneOnSubclass(org.hibernate.test.onetoone.nopojo.DynamicMapOneToOneTest)
testOneToOneOnSubclass(org.hibernate.test.onetoone.singletable.DiscrimSubclassOneToOneTest)
testPersistOutsideTransaction(org.hibernate.test.generatedkeys.identity.IdentityGeneratedKeysTest)
testPersistOutsideTransactionCascadedToNonInverseCollection(org.hibernate.test.generatedkeys.identity.IdentityGenerate
dKeysTest)
testPersistOutsideTransactionCascadedToInverseCollection(org.hibernate.test.generatedkeys.identity.IdentityGeneratedKe
ysTest)
testPersistOutsideTransactionCascadedToManyToOne(org.hibernate.test.generatedkeys.identity.IdentityGeneratedKeysTest)
testPersistOutsideTransactionCascadedFromManyToOne(org.hibernate.test.generatedkeys.identity.IdentityGeneratedKeysTest
)
testDom4j(org.hibernate.test.entitymode.dom4j.basic.Dom4jTest)
testMapIndexEmision(org.hibernate.test.entitymode.dom4j.basic.Dom4jTest)
testPojoRetreival(org.hibernate.test.entitymode.multi.MultiRepresentationTest)
testDom4jRetreival(org.hibernate.test.entitymode.multi.MultiRepresentationTest)
testDom4jSave(org.hibernate.test.entitymode.multi.MultiRepresentationTest)
testDom4jHQL(org.hibernate.test.entitymode.multi.MultiRepresentationTest)
Tests run: 1381, Failures: 0, Errors: 21, Skipped: 0
Regards,
-Jay
> Nullability.checkNullability() throws PropertyValueException (not-null property references a null property) for a property that ForeignKeys.Nullifier.nullifyTransientReferences() just nulled
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HHH-3544
> URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3544
> Project: Hibernate Core
> Issue Type: Bug
> Components: core
> Affects Versions: 3.3.1
> Environment: Hibernate 3.3.1, Hibernate Annotations 3.4, Hibernate Commons-Annotation 3.3.1, Hibernate EntityManager 3.4, PostgreSQL 8.2.5, Java 5
> Reporter: Jeppe Cramon
> Attachments: 3.3.1.GA-HHH-3544, HibernateNullabilityProblem.zip
>
>
> Nullability.checkNullability throws PropertyValueException (not-null property references a null property) for a property that ForeignKeys.Nullifier.nullifyTransientReferences just nulled.
> I've included an Eclipse Java project which can reproduce the problem (didn't include the jars).
> The problem requires a pretty big graph to be reproduce able. The file "Domain Model.jpg" displays the Classes that take part in the problem.
> The Domain Model is a simplification of the entities from our application.
> In the example, ModelTest.java, there's only one active instance entity of each type (from A to H).
> With the given test case, when an instance of a is passed to entityManager.persist(..), then the following exception is thrown:
> javax.persistence.PersistenceException: org.hibernate.PropertyValueException: not-null property references a null or transient value: dk.hibernatetest.model.C.b
> at org.hibernate.ejb.AbstractEntityManagerImpl.throwPersistenceException(AbstractEntityManagerImpl.java:614)
> at org.hibernate.ejb.AbstractEntityManagerImpl.persist(AbstractEntityManagerImpl.java:226)
> at dk.hibernatetest.model.ModelTest.test(ModelTest.java:49)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.junit.internal.runners.TestMethodRunner.executeMethodBody(TestMethodRunner.java:99)
> at org.junit.internal.runners.TestMethodRunner.runUnprotected(TestMethodRunner.java:81)
> at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
> at org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75)
> at org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45)
> at org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:66)
> at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:35)
> at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
> at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
> at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
> at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:45)
> at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
> at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
> Caused by: org.hibernate.PropertyValueException: not-null property references a null or transient value: dk.hibernatetest.model.C.b
> at org.hibernate.engine.Nullability.checkNullability(Nullability.java:95)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:313)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:636)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:628)
> at org.hibernate.engine.EJB3CascadingAction$1.cascade(EJB3CascadingAction.java:28)
> at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:319)
> at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:265)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:242)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
> at org.hibernate.event.def.AbstractSaveEventListener.cascadeAfterSave(AbstractSaveEventListener.java:479)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:357)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:636)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:628)
> at org.hibernate.engine.EJB3CascadingAction$1.cascade(EJB3CascadingAction.java:28)
> at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
> at org.hibernate.event.def.AbstractSaveEventListener.cascadeBeforeSave(AbstractSaveEventListener.java:454)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:288)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:636)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:628)
> at org.hibernate.engine.EJB3CascadingAction$1.cascade(EJB3CascadingAction.java:28)
> at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
> at org.hibernate.event.def.AbstractSaveEventListener.cascadeBeforeSave(AbstractSaveEventListener.java:454)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:288)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:636)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:628)
> at org.hibernate.engine.EJB3CascadingAction$1.cascade(EJB3CascadingAction.java:28)
> at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
> at org.hibernate.event.def.AbstractSaveEventListener.cascadeBeforeSave(AbstractSaveEventListener.java:454)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:288)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:636)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:628)
> at org.hibernate.engine.EJB3CascadingAction$1.cascade(EJB3CascadingAction.java:28)
> at org.hibernate.engine.Cascade.cascadeToOne(Cascade.java:291)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:239)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascadeCollectionElements(Cascade.java:319)
> at org.hibernate.engine.Cascade.cascadeCollection(Cascade.java:265)
> at org.hibernate.engine.Cascade.cascadeAssociation(Cascade.java:242)
> at org.hibernate.engine.Cascade.cascadeProperty(Cascade.java:192)
> at org.hibernate.engine.Cascade.cascade(Cascade.java:153)
> at org.hibernate.event.def.AbstractSaveEventListener.cascadeAfterSave(AbstractSaveEventListener.java:479)
> at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:357)
> at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:204)
> at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:144)
> at org.hibernate.ejb.event.EJB3PersistEventListener.saveWithGeneratedId(EJB3PersistEventListener.java:49)
> at org.hibernate.event.def.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:154)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:110)
> at org.hibernate.event.def.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:61)
> at org.hibernate.impl.SessionImpl.firePersist(SessionImpl.java:645)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:619)
> at org.hibernate.impl.SessionImpl.persist(SessionImpl.java:623)
> at org.hibernate.ejb.AbstractEntityManagerImpl.persist(AbstractEntityManagerImpl.java:220)
> ... 21 more
> As noted in TestModel.java, if some of the other entities (namely c, g or h) are passed to persist(), then the problem doesn't occur.
> I've tried to debug the problem and the only difference I've seen inside ForeignKeys.Nullifier.nullifyTransientReferences() is that, in the cases where an exception is thrown, then the B instance that C.b points to has the state SAVING, whereas when the exception isn't thrown, then it has state MANAGED.
> When the B instance has state SAVING, then ForeignKeys.Nullifier.nullifyTransientReferences() nulls then entry in it's value array.
> After that, Nullability.checkNullability(), performs a null check, which fails because ForeignKeys.Nullifier.nullifyTransientReferences() just nulled the property in the values array.
> Could it be a solution to reverse the order of the ForeignKeys.Nullifier.nullifyTransientReferences() and Nullability.checkNullability() (See AbstractEventListener.performSaveOrReplicate(...))
> or does ForeignKeys.Nullifier.nullifyTransientReferences() instead have to take nullability into considerations?
> /Jeppe
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list