[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3401) H2 Database Dialect Fixes

[Thomas Mueller (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32231#action_32231 ] 

Thomas Mueller commented on HHH-3401:
-------------------------------------

Hi Chris,

> we're missing some coverage

Yes, it looks like.

> Certainly the 3.3 testsuite covers this

Yes, but the testsuite doesn't seem to test 'reloading'. It is probably possible to test this feature, but I'm not familiar with the Hibernate test suite. If you want me to write a better test case then it would take some more time I'm afraid...

> why vendors that maintain/contribute Dialects just don't ship them

The dialect is included in H2 under h2/src/tools/org/hibernate/dialect/H2Dialect.java.txt (I renamed it to .txt so that I don't have to add a dependency to Hibernate). I could include the class file in the h2*.jar, but that would not help if the Hibernate jar file is loaded first. Also, writing a dialect that works with all versions of Hibernate could be hard.

Regards,
Thomas


> H2 Database Dialect Fixes
> -------------------------
>
>                 Key: HHH-3401
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3401
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>            Reporter: Thomas Mueller
>            Assignee: Chris Bredesen
>         Attachments: H2Dialect.java, H2Dialect.java.patch, test.zip
>
>
> There are a few bugs in the H2 Dialect:
> - There is no native BIT data type in H2.
> - The database function DATEDIFF does have parameters
> - There is a typo in function QUARTER
> I have created a patch and a simple test case: The problem with the BIT / BOOLEAN data type appears if you run the test twice. Please tell me if you need more information.
> Regards,
> Thomas

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira