[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2655) SQLServer2005Dialect (ROW_NUMBER for Paging)

[Andrei Chirila (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=33563#action_33563 ] 

Andrei Chirila commented on HHH-2655:
-------------------------------------

Joao, there seems to be a bug in your implementation. "TOP offset + last" does not always translate to "TOP 100 percent". Currently, your implementation covers only the case when offset = 0. 
If this solution is indeed an improvement, the percentage should be computed depending on the value of the offset. With respect to code clarity, I personally consider the "TOP offset + last" solution to be better than a "TOP x percent" one; but if performance is considerably improved, this is definitely worth it.


> SQLServer2005Dialect (ROW_NUMBER for Paging)
> --------------------------------------------
>
>                 Key: HHH-2655
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2655
>             Project: Hibernate Core
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 3.2.2, 3.2.3, 3.2.4
>         Environment: SQLServer 2005, Hibernate 3.2.2+
>            Reporter: Wells Tiedeman
>         Attachments: BindingSqlServerDialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java
>
>   Original Estimate: 1 minute
>  Remaining Estimate: 1 minute
>
> Add a SQLServer2005Dialect class to the product that leverages the new ROW_NUMBER capabilities within SQLServer2005 to do paged result sets more efficiently.  See attached source...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira