[hibernate-issues] [Hibernate-JIRA] Commented: (HV-90) Use jType for generic style subclass discovery

[Hardy Ferentschik (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32613#action_32613 ] 

Hardy Ferentschik commented on HV-90:
-------------------------------------

I had a quick look at the shading plugin. Not sure if I like the implications. If you want to include/shade the jtype dependency into the HV jar you still need to reference the dependency in the pom. This means that people using maven will automatically get the jtype dependency as well when they use HV. Unless, of course you mark the dependency as optional. This would prevent maven to pull jtype transitively. However, it would create of course the wrong impression since the dependency is of course not optional.
Also, if you apply the relocation functionality  to for example com.googlecode.jtype to org.hibernate.util.jtype the shade-plugin must apply some byte code modifications. I could image that that could 
cause problems during debugging.

For me the share-plugin seems to be more for standalone applications and not so much for libraries like HV. I guess then I prefer to include the sources under org.hibernate.validator.util.jtype and manage any up-/downstream changes manually.

> Use jType for generic style subclass discovery
> ----------------------------------------------
>
>                 Key: HV-90
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-90
>             Project: Hibernate Validator
>          Issue Type: New Feature
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>             Fix For: 4.0.0.Alpha3
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira