[hibernate-issues] [Hibernate-JIRA] Commented: (HV-128) Support Iterable

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32672#action_32672 ] 

Emmanuel Bernard commented on HV-128:
-------------------------------------

I tried to convert the name of the method but found issues.

Path cannot reach a particular object for Set and Collection already. That's a separate concern but I had a few ideas last night.




> Support Iterable
> ----------------
>
>                 Key: HV-128
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-128
>             Project: Hibernate Validator
>          Issue Type: Improvement
>          Components: engine
>    Affects Versions: 4.0.0.Alpha2
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>             Fix For: 4.0.0.Alpha3
>
>
> I tried to implement it myself but several part of the code held me off.
> It seems ReflectionHelper is fairly buggy.
> The idea was to convert isCollection, getCollectionClass, isCollectionClass to isIterable, getIterableClass, isIterableClass. It is straightforward except that in various places, the code expect Map to be a subclass of Collection which it is *not*:
>    ReflectionHelper.getIndexedType assumes so
>    ReflectionHelper.getIndexedValue assumes so
> I suspect Map is not tested.
> Also the code seems to consider every Collection as indexed (but I might be wrong)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira