[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1985) NodeTraverser is not SOE-safe

[Laurent Delaforge (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=32678#action_32678 ] 

Laurent Delaforge commented on HHH-1985:
----------------------------------------

I don't understand why this issue is a "Minor Improvement" while the duplicate issue HHH-2166 is a "Major Bug".
It would be a good idea to blend the duplicate.

In my humble opinion it is a bug, not an improvement.
Minor or major, I am not able to say

> NodeTraverser is not SOE-safe
> -----------------------------
>
>                 Key: HHH-1985
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1985
>             Project: Hibernate Core
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.2.0.cr3
>            Reporter: Sergey Vladimirov
>            Priority: Minor
>         Attachments: patch.txt
>
>
> org.hibernate.hql.ast.util.NodeTraverser
> It is possible for java.lang.StackOverflowError to occur in NodeTraverser.java:41;42 with very deep tree. Need another algorith to visit whole tree.
> 08.08 19:50:09 ERROR [ArpSiteServlet] Servlet.service() for servlet ArpSiteServlet threw exception
> java.lang.StackOverflowError
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira