[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1829) Allow join on any property using property-ref

[Anthony Patricio (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34558#action_34558 ] 

Anthony Patricio commented on HHH-1829:
---------------------------------------

Hi Mathieu,
I ported and tested the patch on trunk.

Here are my comments:
- it works, makes the feature available
- it doesn't impact the results of the testsuite so no new bugs

HOWEVER
- hibernate annotation doesn't compile anymore, that's a first big issue
- the impact is huge and complex, SingleTableEntityPersister, Queryable,Loadable,EntityPersister, PersistentClass, MultiTableUpdateExecutor, MultiTableDeleteExecutor, AbstractStatementExecutor but mainly in AbstractEntityPersister

These changes make the code more complex to maintain.

Did you think of other ways this could be implemented or was it the only option available? 

In a future release (3.6/3.7), a new metadata API will be available. It will offer the ability to point a FK at a column other than the PK. This is exactly what is needed here but unfortunately not easy at all with the current design. Maybe it could be much more interesting to wait until 3.6/3.7. What do you think?

> Allow join on any property using property-ref
> ---------------------------------------------
>
>                 Key: HHH-1829
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829
>             Project: Hibernate Core
>          Issue Type: New Feature
>          Components: metamodel
>    Affects Versions: 3.2.0 cr1, 3.2.0.cr2
>            Reporter: Maarten Winkels
>            Assignee: Anthony Patricio
>         Attachments: AbstractJoinTest.java, HHH-1829-3.2.8-SNAPSHOT.patch, HHH-1829-mwinkels.patch, hhh-1829.patch, JoinNoPropertyRefTest.java, JoinPropertyRefTest.java, Person.hbm.xml, Person.java, PersonNoPropertyRef.hbm.xml
>
>
> Currently joining tables for one class (uing the <join...> tag) is only supported for the id property. The property-ref is allowed on the <key..> tag inside the <join..> tag, but this is ignored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira