[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-4499) Account for modules needing JDK 1.6

Chris Wilson (JIRA) noreply at atlassian.com
Mon Nov 30 08:21:08 EST 2009


    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34810#action_34810 ] 

Chris Wilson commented on HHH-4499:
-----------------------------------

I tried "mvn -Djdk16_home=/usr/lib/jvm/java-6-sun install" and that failed with a mysterious error from Javassist that it couldn't find java.lang.String.

I don't see why it should be incumbent on all users to set jdk16_home outside of the build process if Hibernate can be built using jdk 1.6, thus removing the need to do so.

So this "fix" actually makes life more difficult for developers who want to contribute to Hibernate (e.g. submitting patches), without solving the real problem which was jdk 1.6 compatibility, that has now been solved independently in any case.

> Account for modules needing JDK 1.6
> -----------------------------------
>
>                 Key: HHH-4499
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4499
>             Project: Hibernate Core
>          Issue Type: Task
>          Components: build
>            Reporter: Steve Ebersole
>            Assignee: Steve Ebersole
>             Fix For: 3.5.0-Beta-2
>
>
> Currently both the hibernate-infinispan and hibernate-jdb4-testing modules need JDK 1.6, whereas the rest of Hibernate needs to be built using JDK 1.5.  The solution is to fork both javac and surefire to pass in the JDK:
>             </plugin>
>                 <groupId>org.apache.maven.plugins</groupId>
>                 <artifactId>maven-compiler-plugin</artifactId>
>                 <configuration>
>                     <executable>${jdk16_home}/bin/javac</executable>
>                     <fork>true</fork>
>                     <verbose>true</verbose>
>                     <compilerVersion>1.6</compilerVersion>
>                     <source>1.6</source>
>                     <target>1.6</target>
>                 </configuration>
>             </plugin>
>             <plugin>
>                 <groupId>org.apache.maven.plugins</groupId>
>                 <artifactId>maven-surefire-plugin</artifactId>
>                 <configuration>
>                     <jvm>${jdk16_home}/bin/java</jvm>
>                     ...
>                 </configuration>
>             </plugin>
> Notice the use of the jdk16_home property to allow this to be customized to each developers machine...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list