[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1829) Allow join on any property using property-ref

[Mathieu Gervais (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34210#action_34210 ] 

Mathieu Gervais commented on HHH-1829:
--------------------------------------

HHH-1829-3.2.8-SNAPSHOT.patch attached. Some details:

Essentially the mwinkels patch, updated for 3.2.8 + combining the tests on this jira into the patch.
We ran the tests on a patched 3.2.8-SNAPSHOT jar and they passed.

The patch was verified on an application as well (there were some unrelated issues with the upgrade to 3.2.8 itself, but this patch worked). 
This verification was in QA, not prod.

Also, I contacted the original patch author (mwinkels) and while he doesn't have any cycles to work on this he provided the following background information for the patch:

-Main changes are in HBMBinder to collect the foreign-key value when set in the mapping and store it in the mapping model.

-Then in the SingleTableEntityPersister there are some changes to work with the join, creating the correct join statements for inserts and queries.

-The rest of the patch basically works to cascade these changes to the concerned classes.

Let us know if we can do anything else to help. Thanks.

> Allow join on any property using property-ref
> ---------------------------------------------
>
>                 Key: HHH-1829
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829
>             Project: Hibernate Core
>          Issue Type: New Feature
>          Components: metamodel
>    Affects Versions: 3.2.0 cr1, 3.2.0.cr2
>            Reporter: Maarten Winkels
>            Assignee: Anthony Patricio
>         Attachments: AbstractJoinTest.java, HHH-1829-3.2.8-SNAPSHOT.patch, HHH-1829-mwinkels.patch, hhh-1829.patch, JoinNoPropertyRefTest.java, JoinPropertyRefTest.java, Person.hbm.xml, Person.java, PersonNoPropertyRef.hbm.xml
>
>
> Currently joining tables for one class (uing the <join...> tag) is only supported for the id property. The property-ref is allowed on the <key..> tag inside the <join..> tag, but this is ignored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira