[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-756) schema export tool does not check for apostrophe within the <comment></comment> tags

[Chris Wilson (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=34285#action_34285 ] 

Chris Wilson commented on HHH-756:
----------------------------------

One option would be to allow Hibernate users to disable the export of comments. Currently this only checks whether the dialect supports comments or not:

	public Iterator sqlCommentStrings(Dialect dialect, String defaultCatalog, String defaultSchema) {
		List comments = new ArrayList();
		if ( dialect.supportsCommentOn() ) {

If we could add a configuration property to disable the generation of SQL comment strings, then I could avoid this error, while still having comments with apostrophes in the mapping files.

> schema export tool does not check for apostrophe  within the <comment></comment> tags
> -------------------------------------------------------------------------------------
>
>                 Key: HHH-756
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-756
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.0.5
>            Reporter: Craig Baker
>            Priority: Trivial
>
> If an apostrophe appears within <comment> </comment> tag, schema export tool fails to create valid DDL syntax.
> eg.
> <hibernate-mapping>
> ..
> <comment>The user's session</user>
> ..
> </hibernate-mapping>
> produces
> create table (
> ..
> ) comment = 'The user's session';

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira