[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-421) Exceptions happening in backend are unnoticed (Amin Mohammed-Coleman)

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36121#action_36121 ] 

Sanne Grinovero commented on HSEARCH-421:
-----------------------------------------

Hi Amin,
I see you're still loosing the fight with your ide about controlling the tabs/spaces :D

The code is ok, I'm applying it with some more changes:
* tabs
* An additional ErrorHandler which rethrows the exceptions, this one is only meaningfull when backend is working in sync mode, so the factory sill throw a SearchException is it's configured with an async backend.
* the LuceneBackendQueueProcessor won't flag the whole queue failed, we don't know in this context - it might propagate the error generated from the index worker which is already containing such information.
* Added tests for the new ErrorHandler

I'll wait for you to document the two configurable ErrorHandlers to close the issue (please read the keywords needed for configuration from SearchFactoryImpl and notice that the logging one is default for async, while propagating back the exception is the default for sync.

> Exceptions happening in backend are unnoticed (Amin Mohammed-Coleman)
> ---------------------------------------------------------------------
>
>                 Key: HSEARCH-421
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-421
>             Project: Hibernate Search
>          Issue Type: Bug
>          Components: engine
>    Affects Versions: 3.1.0.GA, 3.1.1.GA
>            Reporter: Sanne Grinovero
>            Assignee: Sanne Grinovero
>             Fix For: 3.2.0.CR1
>
>         Attachments: HibernateSearch-421-01042010.patch, HibernateSearch-421-04042010.patch, HibernateSearch-421-24032010-FixedStyle.patch, HibernateSearch-421-24032010.patch, HSEARCH-421-3-4-2010.patch
>
>
> Any exception happening in the backend is not noticed as it happens in a separate thread.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira