[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36328#action_36328 ] 

Sanne Grinovero commented on HHH-3543:
--------------------------------------

nice solution, but you likely need to update the title?
having "DBCTransaction.notifyLocalSynchsBeforeTransactionCompletion swallow the transactions" is still true right? so I think we should either reject this and open another for the Envers fix or rename this issue or it will be quite misleading in changelogs.

> method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HHH-3543
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.3.1
>         Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
>            Reporter: Roman
>            Assignee: Adam Warski
>             Fix For: 3.5.x
>
>   Original Estimate: 32h
>  Remaining Estimate: 32h
>
> When using JBoss Envers any exceptions occured during saving data into version tables are swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
>                                 try {
> 					sync.beforeCompletion();
> 				}
> 				catch (Throwable t) {
> 					log.error("exception calling user Synchronization", t);
> 				}
> Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but will not have any effect on application functionality
> So I have such behaviour:
> 1. Entity changes are saved in database by hibernate
> 2. Version tables for entities are empty, because, for example, of invalid column names
> 3. Transaction commits successfully.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira