[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-491) Make some optional dependencies mandatory

[G Fernandes (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36336#action_36336 ] 

G Fernandes commented on HSEARCH-491:
-------------------------------------

Hi, the snippet above will be not true anymore for Maven users, in the sense that Solr deps are already resolved including commons-codec and commons-io:

hibernate-search$ mvn dependency:tree
[INFO] ------------------------------------------------------------------------
[INFO] Building Hibernate Search
[INFO]    task-segment: [dependency:tree]
[INFO] ------------------------------------------------------------------------
...
[INFO] +- org.apache.lucene:lucene-core:jar:2.9.2:compile
[INFO] +- org.apache.solr:solr-core:jar:1.4.0:compile
[INFO] |  +- org.apache.solr:solr-solrj:jar:1.4.0:compile
[INFO] |  +- commons-codec:commons-codec:jar:1.3:compile
[INFO] |  \- commons-io:commons-io:jar:1.4:compile
[INFO] +- org.apache.lucene:lucene-snowball:jar:2.9.2:compile
[INFO] +- org.apache.lucene:lucene-analyzers:jar:2.9.2:compile
...

For non-maven users, yes, it stays true, but all deps are being packaged in the dist assembly anyway.

Regarding lucene-analyzers and lucene-snowball, I think since Solr 1.4 deps will be mandatory, it won't hurt to make them also mandatory, since they are very small and have no transitive dependencies at all.

> Make some optional dependencies mandatory
> -----------------------------------------
>
>                 Key: HSEARCH-491
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-491
>             Project: Hibernate Search
>          Issue Type: Improvement
>          Components: build, documentation
>            Reporter: Emmanuel Bernard
>            Assignee: Emmanuel Bernard
>             Fix For: 3.2.0.CR1
>
>         Attachments: solrNotOptional.patch
>
>
> Need to change the pom, the artifact and the documentation (esp the getting started one).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira