[hibernate-issues] [Hibernate-JIRA] Created: (HHH-5095) BasicLoader.isBag() checks type assignability wrongly

[Matt Benson (JIRA)]

BasicLoader.isBag() checks type assignability wrongly
-----------------------------------------------------

                 Key: HHH-5095
                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095
             Project: Hibernate Core
          Issue Type: Bug
          Components: core
    Affects Versions: 3.5.0-Final
         Environment: N/A
            Reporter: Matt Benson


Method defined as:

{code}
private boolean isBag(CollectionPersister collectionPersister) {
        return collectionPersister.getCollectionType().getClass().isAssignableFrom( BagType.class );
}
{code}

Will never return true if the returned CollectionType subclasses BagType; should IMO be:

{code}
private boolean isBag(CollectionPersister collectionPersister) {
        return BagType.class.isInstance( collectionPersister.getCollectionType() );
}
{code}

My humble apologies for the submission without a test case, but this one feels pretty simple.  Thanks!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira