[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-3543) method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
Adam Warski (JIRA)
noreply at atlassian.com
Sat Apr 10 05:17:00 EDT 2010
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36359#action_36359 ]
Adam Warski commented on HHH-3543:
----------------------------------
True. Although the original issue is with Envers, and that's fixed, so that's why I closed it.
In fact, users can now choose which mechanizm to use (synchronization or process) if they want the exceptions to propagate or not.
As I understood Steve, only logging the exceptions and not propagating them is the desired behavior and will not change.
> method org.hibernate.transaction.JDBCTransaction.notifyLocalSynchsBeforeTransactionCompletion "swallows" all exceptions occured inside it
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HHH-3543
> URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3543
> Project: Hibernate Core
> Issue Type: Bug
> Components: core
> Affects Versions: 3.3.1
> Environment: MS Windows XP SP2, JDK 1.6.8, Eclipse 3.2.0
> Reporter: Roman
> Assignee: Adam Warski
> Fix For: 3.5.x
>
> Original Estimate: 32h
> Remaining Estimate: 32h
>
> When using JBoss Envers any exceptions occured during saving data into version tables are swallowed by code block in class org.hibernate.transaction.JDBCTransaction (line 273):
> try {
> sync.beforeCompletion();
> }
> catch (Throwable t) {
> log.error("exception calling user Synchronization", t);
> }
> Thereby, any exceptions occured in sync.beforeCompletion() will only be shown in log, but will not have any effect on application functionality
> So I have such behaviour:
> 1. Entity changes are saved in database by hibernate
> 2. Version tables for entities are empty, because, for example, of invalid column names
> 3. Transaction commits successfully.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list