[hibernate-issues] [Hibernate-JIRA] Created: (HV-316) Extract constraint checking from ConstraintAnnotationVisitor into separate check classes
Gunnar Morling (JIRA)
noreply at atlassian.com
Tue Apr 27 18:22:33 EDT 2010
Extract constraint checking from ConstraintAnnotationVisitor into separate check classes
----------------------------------------------------------------------------------------
Key: HV-316
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-316
Project: Hibernate Validator
Issue Type: Improvement
Components: annotation-processor
Affects Versions: 4.1.0.Beta1
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Fix For: 4.1.0
Currently the class ConstraintAnnotationVisitor contains all the logic related to constraint checking. For all the different checks (appropriate type, getters not setters annotated etc.) there are check methods, causing the class to become larger and larger as new checks are added.
To improve maintainability all the checks shall be extracted to dedicated check classes. A factory should know which checks have to be executed for given elements and annotations. The visitor should just call this factory, invoke all returned checks and report all errors possibly occurred.
This issue is a pure refactoring, no functionality will be added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list