[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5428) collection tables are improperly non-quoted when the owning table is quoted

[Steve Ebersole (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38037#action_38037 ] 

Steve Ebersole commented on HHH-5428:
-------------------------------------

I suppose you mean this change: http://fisheye.jboss.org/browse/Hibernate/core/trunk/core/src/main/java/org/hibernate/cfg/HbmBinder.java?r=20092#l1471

But IMHO thats not a bug in HBMBinder.  You are just making an assumption here that if the owner table name is quoted the association table name should be quoted as well.  So I guess the question is whether that is a valid assumption.  

As an example, consider that a owner table name is {{`!*FOOBAR$&`}}.  We ask the naming strategy to build the "collection table name" and it returns {{ABC_XYZ}}.  Right now, we quote this even though the naming strategy has taken care of it.  This is more than just ugly, it could cause real problems.

> collection tables are improperly non-quoted when the owning table is quoted
> ---------------------------------------------------------------------------
>
>                 Key: HHH-5428
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428
>             Project: Hibernate Core
>          Issue Type: Bug
>    Affects Versions: 3.5.4, 3.6.0.Beta1
>            Reporter: Emmanuel Bernard
>             Fix For: 3.6.0.Beta3
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira