[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-4453) Reserved keywords not quoted in table/column names

[Maarten Billemont (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35460#action_35460 ] 

Maarten Billemont commented on HHH-4453:
----------------------------------------

It is definitely the responsability of hbm2ddl to sanitize column names for use in the generated schema. An entity is perfectly valid if it has only an @Entity and an @Id according to the specification; though Hibernate will generate a broken schema for that entity if it happens to contain fields that are keywords in whatever dialect the developer happens to be exporting to.

It is unreasonable to expect that developers know all (or any!) keywords of the underlying dialect that they use; or will use in the future.  This is, after all, an *abstraction*.  It should no expose things like this.  I'm actually rather stumped to see no progress has been made on this front for the longest time.

> Reserved keywords not quoted in table/column names
> --------------------------------------------------
>
>                 Key: HHH-4453
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4453
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.3.1
>         Environment: Hibernate 3.3.1 GA, Windows XP, Sun JDK 1.6.0_06, Derby 10.5
>            Reporter: Philipp Reichart
>
> I'm currently migrating our test suite form HSQLDB to Derby (we need transaction isolation and the HSLDB 1.9 RCs are no good), and found out that we have a lot of table or colum names that happen to be reserved keywords in Derby, like "transaction", "key", "value", "year", etc..
> The usual workaround seems to be adding backticks to any offending table/column name in our hbm.xml files, but that's really an ugly workaround and doesn't prevent later incidents of this kind when new keywords show up in either our mappings or database. As this is about a production database schema, reanming the table/column names isn't an option either.
> I already tried implementing a custom Derby dialect and registering all the keywords from the Derby doc at http://db.apache.org/derby/docs/10.5/ref/rrefkeywords29722.html and even defined a "quote everything" NamingStrategy using the dialect to get the correct native quotes for the database.
> Unfortunately, neither the Hibernate DDL generator nor HQL queries seem to consider the naming strategy or dialect when handling table or column names.
> Is there any way to have Hibernate quote database-specific keywords every they're used?
> Or just have Hibernate quote everything that comes from a mapping file?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira