[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-1985) NodeTraverser is not SOE-safe

[Benjamin Truitt (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35488#action_35488 ] 

Benjamin Truitt commented on HHH-1985:
--------------------------------------

I see that this issue is resolved in trunk and in the 3.3.1 branch, but if you download 3.3.1.GA, it is not resolved in the source bundled in that download.

This is also true for hibernate 3.3.2.GA.

However, the issue does appear to be resolved in 3.5.0-Beta-4.

Here are the download links I am referring to:
http://sourceforge.net/projects/hibernate/files/

I'm confused about why this fix isn't included in 3.3.1.  Is there any reason I shouldn't download the source for 3.3.1, replace the source code for this file with the latest version from trunk, and rebuild?  

Thanks.

> NodeTraverser is not SOE-safe
> -----------------------------
>
>                 Key: HHH-1985
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1985
>             Project: Hibernate Core
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.2.0.cr3
>            Reporter: Sergey Vladimirov
>            Assignee: Strong Liu
>            Priority: Minor
>         Attachments: patch.txt
>
>
> org.hibernate.hql.ast.util.NodeTraverser
> It is possible for java.lang.StackOverflowError to occur in NodeTraverser.java:41;42 with very deep tree. Need another algorith to visit whole tree.
> 08.08 19:50:09 ERROR [ArpSiteServlet] Servlet.service() for servlet ArpSiteServlet threw exception
> java.lang.StackOverflowError
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:41)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)
>         at org.hibernate.hql.ast.util.NodeTraverser.visitDepthFirst(NodeTraverser.java:42)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira