[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-4689) Make sure @OrderBy supports dotted notation to point to embedded properties

[Scott Marlow (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35134#action_35134 ] 

Scott Marlow commented on HHH-4689:
-----------------------------------

I have two questions about the attached BinderHelper.patch (contains new findPropertyByName(Component component, String propertyName)).

1.  I didn't add support for obtaining the primary key columns.  I assume that is needed and will work on a test case that shows the need.  Do you agree that is probably needed?

2.  For IdentifierMapper support, I used the component.getOwner().getIdentifierMapper() since I don't have a PersistentClass for the Component itself.  I find it unlikely that the component owners identifier mapper will help with component level mapping but need to research that.  I'm not sure if I should just delete the identifier mapper support or come up with a way for component level identifier mapping information to be obtained.  Thoughts?



> Make sure @OrderBy supports dotted notation to point to embedded properties
> ---------------------------------------------------------------------------
>
>                 Key: HHH-4689
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4689
>             Project: Hibernate Core
>          Issue Type: Sub-task
>          Components: annotations
>            Reporter: Emmanuel Bernard
>            Assignee: Scott Marlow
>         Attachments: BinderHelper.patch, CollectionBinder.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira