[hibernate-issues] [Hibernate-JIRA] Commented: (HV-353) Support inheritance for marker interfaces

Hardy Ferentschik (JIRA) noreply at atlassian.com
Thu Jul 15 05:51:16 EDT 2010


    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37799#action_37799 ] 

Hardy Ferentschik commented on HV-353:
--------------------------------------

I don't get it, do you actually have a usecase where this doesn't work? Group inheritance is part of the Bean Validation spec and there is a for example a test in the TCK - [GroupInheritanceTest.testGroupCanInheritGroupsViaInterfaceInheritance|http://fisheye.jboss.org/browse/Hibernate/beanvalidation/tck/trunk/src/main/java/org/hibernate/jsr303/tck/tests/constraints/groups/inheritance/GroupInheritanceTest.java?r=HEAD]. AFAICS the test covers pretty much your usecase. 
I will wait for a while for a test case showing any problems. If I don't hear anything I'll resolve the issue.

> Support inheritance for marker interfaces
> -----------------------------------------
>
>                 Key: HV-353
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-353
>             Project: Hibernate Validator
>          Issue Type: Improvement
>          Components: engine
>    Affects Versions: 4.1.0.Final
>            Reporter: Marc Schipperheyn
>            Assignee: Hardy Ferentschik
>             Fix For: 4.2.0
>
>
> Currently, constraints use marker interface specified in the group attribute to determine whether a constraint is active for a certain context. 
> Unfortunately, group membership doesn't seem to support inheritance which would greatly reduce the number of markers required (and processing since you need less markers).
> E.g. (contrived)
> {code}
> public interface CheckVehicle{}
> public interface CheckCar extends CheckVehicle{}
> public interface CheckBicycle extends CheckVehicle{}
> //bean
> @AssertTrue(groups={CheckVehicle.class})
> Boolean workingBrakes()
> @NotNull(groups={CheckBicycle.class})
> String brakeType()
> {code}
> If the active group is CheckBicycle, it should validate  both workingBrakes and brakeType.
> It should be a relatively simply change as well. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list