[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5381) HSQLDB new dialect (Fred Toussi)

[Fred Toussi (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37869#action_37869 ] 

Fred Toussi commented on HHH-5381:
----------------------------------

I have an updated version that reflects some user feedback with existing databases upgraded to 2.0 and new databases.

In this version BOOLEAN is included in the list of types and the literal values for BOOLEAN are defined as "true" or "false" instead of "1" or "0".

Both v. 1.8.x and 2.0 support BOOLEAN (with true and false). In 1.8.x BIT is a synonym for BOOLEAN. In 2.0, BIT is a separate type representing a bit map which can have 0 or 1. As BOOLEAN is the prefered type in terms of storage requirements and usage in queries, it is better if this is used directly.

I did not make this change initially as I was concerned about possible effects with existing databases. It now seems the change has no side effects and actually results in better SQL conformance.


changes:

    registerColumnType( Types.BOOLEAN, "boolean" );

    public boolean supportsUnionAll() {
        return true;
    }

    public String toBooleanValueString(boolean bool) {
        return bool ? "true" : "false";
    }

cannot attache file, which is is at:

http://hsqldb.svn.sourceforge.net/viewvc/hsqldb/base/trunk/src/org/hibernate/dialect/

> HSQLDB new dialect (Fred Toussi)
> --------------------------------
>
>                 Key: HHH-5381
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5381
>             Project: Hibernate Core
>          Issue Type: Patch
>          Components: core
>    Affects Versions: 3.5.x
>         Environment: Hibernate 3.x, HSQLDB 1.8.x and 2.0.x
>            Reporter: Fred Toussi
>            Assignee: Steve Ebersole
>             Fix For: 3.5.4, 3.6.0.Beta1
>
>         Attachments: HSQLDialect.java
>
>          Time Spent: 53m
>  Remaining Estimate: 0h
>
> New version of HSQLDialect.java adjusts its method calls according to the version of hsqldb.jar.
> Supports HSQLDB 1.8.x features exactly as previous versions of the dialect, with a few minor enhancements. 
> Supports HSQLDB 2.0.x features, including trascaction support.
> Has been tested with Hibernate trunk test suite since mid June; latest tests done yesterday.
> For testing, please use the latest HSQLDB 2.0.1 snapshot from http://hsqldb.org/support/ page. The dialect works with the release version of HSQLDB 2.0.0, but shows a few errors with the Hibernate test suite.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira