[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5204) Introduce @RequiresDialectFeature annotation

[Hardy Ferentschik (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37298#action_37298 ] 

Hardy Ferentschik commented on HHH-5204:
----------------------------------------

Yes it was fixed. I just committed another change to align SkipForDialect, RequiresDialect and RequiresDialectFeature. So from my perspective this is resolved. What about the back porting side? Is this supposed to be backported?

> Introduce @RequiresDialectFeature annotation
> --------------------------------------------
>
>                 Key: HHH-5204
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5204
>             Project: Hibernate Core
>          Issue Type: Bug
>          Components: testsuite
>    Affects Versions: 3.5.1
>            Reporter: Hardy Ferentschik
>            Assignee: Hardy Ferentschik
>             Fix For: 3.5.x, 3.6
>
>
> This will allow us to:
> * get rid of {{HibernateTestCase.runForCurrentDialect}}
> * handle skipping of tests more consistently
> At the same time we have to fix an issue {{HibernateTestCase.determineSkipByDialect}}. The logic in the if statement should be inverted.
> Last but not least we can get rid of some unused member variables

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira