[hibernate-issues] [Hibernate-JIRA] Created: (HHH-5710) incorrect test logic of org.hibernate.test.readonly.ReadOnlyCriteriaQueryTest

Strong Liu (JIRA) noreply at atlassian.com
Tue Nov 2 01:56:47 EDT 2010


incorrect test logic of org.hibernate.test.readonly.ReadOnlyCriteriaQueryTest
-----------------------------------------------------------------------------

                 Key: HHH-5710
                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5710
             Project: Hibernate Core
          Issue Type: Bug
          Components: testsuite
    Affects Versions: 3.6.0
            Reporter: Strong Liu
            Assignee: Strong Liu
            Priority: Minor
             Fix For: 3.6.1, 4.0.0.Alpha1


the org.hibernate.test.readonly.ReadOnlyCriteriaQueryTest.testTwoAliasesCache() has a mistake
{quote}
			assertEquals( list.size(), 2 );

			Enrolment e = ( Enrolment ) list.get( 0 );
			if ( e.getStudent().getStudentNumber() == xam.getStudentNumber() ) {
				enrolment1 = e;
				enrolment2 = ( Enrolment ) list.get( 1 );
			}
			else if ( e.getStudent().getStudentNumber() == xam.getStudentNumber() ) {
				enrolment2 = e;
				enrolment1 = ( Enrolment ) list.get( 1 );
			}
			else {
				fail( "Enrolment has unknown student number: " + e.getStudent().getStudentNumber() );
			}
{quote}
it checks the xam.getStudentNumber() twice, which one of them should be gavin's

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list