[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-614) FileNotFoundException during slave synchronization with source

[Michael Mogley (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38943#action_38943 ] 

Michael Mogley commented on HSEARCH-614:
----------------------------------------

I would love to contribute a patch. Unforunately, I don't have bandwidth for this at the moment.  But here's what I'll say.  The solution needs to be blackboxed.  I agree any good application needs monitoring, but I don't want to have to understand the details of the Hibernate Search syncing algorithm. I just want it to work. I propose a couple of solutions. 

1) Implement directory locking.  To get around the issue of a failed slave not giving up the lock, I would implement leased locking, whereby the slave leases the lock for a time it specifies (could be configurable). The lease expiration time could be embedded in the lock file. A thread on the master would periodically check existing locks and forcibly release them if expired.

2) Instead of refreshing on an interval, refresh on a cron schedule. I've actually already implemented a modified FSMaster/SlaveDirectoryProvider to do this.  This allows me to guarantee that both master/slave refresh times are scheduled around each other, and does not depend on when either one was started.

> FileNotFoundException during slave synchronization with source
> --------------------------------------------------------------
>
>                 Key: HSEARCH-614
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-614
>             Project: Hibernate Search
>          Issue Type: Bug
>          Components: directory provider
>    Affects Versions: 3.1.0.GA, 3.1.1.GA, 3.2.0.Final, 3.2.1, 3.3.0.Beta2
>         Environment: Hibernate 3.6, Oracle 10g
>            Reporter: Michael Mogley
>            Priority: Minor
>             Fix For: 3.3.0.CR1
>
>
> The current file synchronization mechanism in the FSSlaveDirectoryProvider has the potential to throw a FileNotFoundException if the source file it's copying is deleted before the copy operation completes.
> https://forum.hibernate.org/viewtopic.php?f=9&t=1007801&p=2437680#p2437680

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira