[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5372) Improve envers query performance by using new REVEND column

[Adam Warski (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38287#action_38287 ] 

Adam Warski commented on HHH-5372:
----------------------------------

The patch is almost good, I'd only like to see the comments on the methods update too - because they are now out of sync with the code.

Also, isn't the code for generating:
// e.revision <= _revision and (e.endRevision > _revision or e.endRevision is null)
duplicated? (OneAuditEntityQueryGenerator, OneEntityQueryGenerator, QueryGeneratorTools)?

Maybe it could be a method on an AuditStrategy, so that an ugly class-check could be avoided?

In the before mentioned classes, the "maxERevQb" object is always created, but only used for the default auditing strategy.

Luckily, no more tests here are necessary, as all tests run twice now: with the two different audit strategies.

> Improve envers query performance by using new REVEND column
> -----------------------------------------------------------
>
>                 Key: HHH-5372
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5372
>             Project: Hibernate Core
>          Issue Type: Improvement
>          Components: envers
>    Affects Versions: 3.6.0.Beta1
>            Reporter: Matthew B. Jones
>            Assignee: Adam Warski
>         Attachments: revend_queries.txt
>
>
> When the ValidTimeAuditStrategy is enabled: <property name="org.hibernate.envers.audit_strategy">org.hibernate.envers.strategy.ValidTimeAuditStrategy</property>, it would be desirable to have the Envers API leverage the useful REVEND columns to avoid slow subselects.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira