[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5543) JEE bootstrapping should only parse and validate mapping files once

Steve Ebersole (JIRA) noreply at atlassian.com
Wed Sep 8 15:47:18 EDT 2010


    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38331#action_38331 ] 

Steve Ebersole commented on HHH-5543:
-------------------------------------

If I understand correctly, after the call to {{addXMLEntities}} we no longer really need the local {{List<String> xmlFiles}} variable for anything other than to pass it to (eventually) {{addClassesToSessionFactory}} so that they get added to the configuration.  Seems to me the solution here is to save the parsed and validated DOM tree, once that code is fixed up ( see HHH-5310 ), and pass that DOM tree into the config via a method that indicates it has already been validated.

> JEE bootstrapping should only parse and validate mapping files once
> -------------------------------------------------------------------
>
>                 Key: HHH-5543
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5543
>             Project: Hibernate Core
>          Issue Type: Improvement
>          Components: entity-manager
>    Affects Versions: 3.5.5, 3.6.0.Beta4
>            Reporter: Steve Ebersole
>            Assignee: Steve Ebersole
>             Fix For: 3.5.6, 3.6.0.CR1
>
>
> Currently mapping files get parsed and validated twice during JEE bootstrapping:
> # once in {{org.hibernate.ejb.Ejb3Configuration#addXMLEntities}} (from {{org.hibernate.ejb.Ejb3Configuration#configure}}, from {{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}}) 
> # again to actually add it to the configuration from {{org.hibernate.ejb.Ejb3Configuration#addClassesToSessionFactory}} (from {{org.hibernate.ejb.Ejb3Configuration#configure}}, from {{org.hibernate.ejb.HibernatePersistence#createContainerEntityManagerFactory}})
> AFAICT, the first occurrence is used to identify classes for potential enhancement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list