[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5562) Improve how event listeners are handled and introduce a serivice pattern for integrators to leverage
Emmanuel Bernard (JIRA)
noreply at atlassian.com
Thu Sep 16 10:20:22 EDT 2010
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38421#action_38421 ]
Emmanuel Bernard commented on HHH-5562:
---------------------------------------
A couple of remarks from my integration with HSearch
1. I would adjsut the API to allow the use of varargs when adding listeners
EventListenerRegistry.appendListener(EventType<T> type, T listener) => EventListenerRegistry.appendListener(EventType<T> type, T... listener);
EventListenerRegistry.appendListener(EventType<T> type, T listener, DuplicationResolutionStrategy dupStrategy) => EventListenerRegistry.appendListener(EventType<T> type, DuplicationResolutionStrategy dupStrategy, T... listener);
2. BV does META-INF/services/org.hibernate.event.spi.EventListenerRegistrationService and not META-INF/org.hibernate.event.spi.EventListenerRegistrationService
I think that's aligned with the recommended approach for the service locator pattern
3. to check for duplication, you use isInstance which surprised me a bit. We might want to add a pluggable mechanism for the isDuplicateOf logi
> Improve how event listeners are handled and introduce a serivice pattern for integrators to leverage
> ----------------------------------------------------------------------------------------------------
>
> Key: HHH-5562
> URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5562
> Project: Hibernate Core
> Issue Type: Improvement
> Components: core
> Reporter: Steve Ebersole
> Assignee: Steve Ebersole
> Fix For: 4.x
>
> Attachments: HHH-5562.patch
>
> Time Spent: 8h 32m
> Remaining Estimate: 0h
>
> Main points:
> # de-dup listener instances registered by classname
> # define a service pattern to allow integrations (search, validator and envers as main targets) to auto register their event listeners
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list