[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-5560) Envers ValidAuditTimeStrategy needs a better name
Erik-Berndt Scheper (JIRA)
noreply at atlassian.com
Mon Sep 20 10:23:22 EDT 2010
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=38451#action_38451 ]
Erik-Berndt Scheper commented on HHH-5560:
------------------------------------------
Adam Warski
{quote}And what do you think about ValidityAuditStrategy?{quote}
> Envers ValidAuditTimeStrategy needs a better name
> -------------------------------------------------
>
> Key: HHH-5560
> URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5560
> Project: Hibernate Core
> Issue Type: Improvement
> Components: envers
> Affects Versions: 3.6.0.Beta4
> Reporter: Erik-Berndt Scheper
> Priority: Minor
>
> See: http://community.jboss.org/thread/156343?tstart=0
> I have been thinking about this some time, but I believe we need a better name for the ValidAuditTimeStrategy.
> Of course, this affects both the class name and the envers configuration option.
> I think we need to do this ASAP (before 3.6.0 goes CR or even GA), because it will cause less incompatibility issues.
> We could keep the old configuration option for compatibility reasons, but that may not be necessary since you marked this as experimental.
>
> There are a couple of reasons why I dislike this name
> * It suggests that AuditTimes can be invalid. I cannot image how this could be the case.
> * We already have AuditStrategy and DefaultAuditStrategy. So it would we logical that the name should end with AuditStrategy.
> * The strategy is based on the use of a revision end column, not on anything like time(stamp)s.
> I propose to rename this strategy to RevisionEndColumnAuditStratigy.
> What do you think? If you agree, I could create an issue with a patch to fix this.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the hibernate-issues
mailing list