[hibernate-issues] [Hibernate-JIRA] Created: (HSEARCH-597) Inconsistent treatment of extended FullTextIndexEventListener

[Ben Dotte (JIRA)]

Inconsistent treatment of extended FullTextIndexEventListener
-------------------------------------------------------------

                 Key: HSEARCH-597
                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-597
             Project: Hibernate Search
          Issue Type: Bug
          Components: engine
    Affects Versions: 3.2.0.Final
         Environment: Hibernate 3.5.3, SQL Server 2005
            Reporter: Ben Dotte
            Priority: Minor


In my hibernate.cfg.xml file I have specified my own hibernate event listener class that extends from FullTextEventListener.java. ContextHelper nicely allows this (line 50):

if ( candidate instanceof FullTextIndexEventListener ) { ... }

However, with debug-level logging turned on, I see a number of log messages from EventSourceTransactionContext line 116 "FullTextIndexEventListener was not registered as FlushEventListener". This is because it looks for an exact class match:

if ( listener.getClass().equals( FullTextIndexEventListener.class ) ) { ... }

Could we change this to be FullTextIndexEventListener.class.isAssignableFrom(listener.getClass()) instead?

I also noticed an == check for the same thing in EventListenerRegister.isPresentInListeners().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira