[hibernate-issues] [Hibernate-JIRA] Commented: (OGM-12) Support more GridTypes

[Emmanuel Bernard (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/OGM-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41954#action_41954 ] 

Emmanuel Bernard commented on OGM-12:
-------------------------------------

Hey
A few remark on your use of Git / GitHub.
You've merge my work from master into your topic branch. This is something we don't do as it creates non linear history and makes it ahrder to read in the end.
http://in.relation.to/Bloggers/HibernateMovesToGitGitTipsAndTricks

When you work on a topic branch, always rebase this work (git rebase master) before pushing it. Note that while you've published the branch to github, it's ok to use rebase as a topic branch is really a work in progress.

To work around your problem, you can create a new branch and cherry pick the two core commits of your work and make sure you rebase in the future.

Wrt GitHub, when you want to share some work, go to your topic branch on github (after pushing it) and you should see a Pull Request button on the top right. This is the preferred way to share as it lists the relevent commits and offer a nice diff option as well as a way to discuss the code.

> Support more GridTypes
> ----------------------
>
>                 Key: OGM-12
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/OGM-12
>             Project: Hibernate OGM
>          Issue Type: New Feature
>            Reporter: Emmanuel Bernard
>            Assignee: Nicolas Helleringer
>
> Today we only support basic numeric and string types
> We should support other types like URL, BigDecimal etc

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira