[hibernate-issues] [Hibernate-JIRA] Commented: (HV-94) Support dynamic default group sequence definition

Gunnar Morling (JIRA) noreply at atlassian.com
Thu Feb 10 18:56:05 EST 2011


    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39921#action_39921 ] 

Gunnar Morling commented on HV-94:
----------------------------------

Applied https://github.com/hibernate/hibernate-validator/pull/23

While looking through this change I noticed that there is the chance that the DefaultGroupSequenceProvider specified for a given type using @GroupSequenceProvider might be parametrized with the wrong type, resulting in a ClassCastException when invoking the provider, see also my commit https://github.com/hibernate/hibernate-validator/commit/44adcf877d2f9323f6caff4ded455978c8c3de68. 

We might check whether the provider is for the right type before invoking it using Class#getGenericInterfaces(). This would surely give a besser user feedback in that case, but of cause such a check wouldn't come for free. WDYT?

> Support dynamic default group sequence definition
> -------------------------------------------------
>
>                 Key: HV-94
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-94
>             Project: Hibernate Validator
>          Issue Type: New Feature
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Assignee: Hardy Ferentschik
>            Priority: Minor
>             Fix For: 4.2.0.Beta2
>
>
> Will probably not be spec'ed in the 1.0 JSR but can be added as a RI feature.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list