[hibernate-issues] [Hibernate-JIRA] Commented: (HHH-2655) SQLServer2005Dialect (ROW_NUMBER for Paging)

[Daniel de Souza Costa Pedroso (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39932#action_39932 ] 

Daniel de Souza Costa Pedroso commented on HHH-2655:
----------------------------------------------------

I got a bug on offset calculation (file SqlServer2008Dialect.java 08/jul/10 3:33 PM).
1 record comes 2 times moving from 1st. page to 2nd page:
 - Given offset = 0 and limit = 5, query will be written 'select top 5...', returning rows from #1 to #5.
 - Given offset = 5 and limit = 10, query will return rows from #5 to #10.
 - row #5 comes twice...
Solution: 
   if(offset > 0) offset++;
 considering that developer will always use zero-based indexing for offset.

> SQLServer2005Dialect (ROW_NUMBER for Paging)
> --------------------------------------------
>
>                 Key: HHH-2655
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2655
>             Project: Hibernate Core
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 3.2.2, 3.2.3, 3.2.4, 3.5.3
>         Environment: SQLServer 2005, Hibernate 3.2.2+
>            Reporter: Wells Tiedeman
>            Assignee: Strong Liu
>             Fix For: 3.6.1, 4.0.0.Alpha1
>
>         Attachments: BindingSqlServerDialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java, SQLServer2005Dialect.java, SqlServer2008Dialect.java, SqlServer2008Dialect.java, SqlServer2008Dialect.java
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> Add a SQLServer2005Dialect class to the product that leverages the new ROW_NUMBER capabilities within SQLServer2005 to do paged result sets more efficiently.  See attached source...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira