[hibernate-issues] [Hibernate-JIRA] Commented: (HV-434) ValidatorImpl#shouldFailFast() and ValidationContext#shouldFailFast() seem redundant

Kevin Pollet (JIRA) noreply at atlassian.com
Thu Feb 17 11:16:06 EST 2011


    [ http://opensource.atlassian.com/projects/hibernate/browse/HV-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40011#action_40011 ] 

Kevin Pollet commented on HV-434:
---------------------------------

Currently, I'm working on HV-429 and I've made some code factorisation. I've added the ValidationContext as a parameter for methods {{validatePropertyForGroup}} and {{validateValueForGroup}}. By doing this, I've seen that the {{ValidatorImpl#shouldFailFast}} method is no longer necessary and I've removed it.

> ValidatorImpl#shouldFailFast() and ValidationContext#shouldFailFast() seem redundant
> ------------------------------------------------------------------------------------
>
>                 Key: HV-434
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-434
>             Project: Hibernate Validator
>          Issue Type: Improvement
>          Components: engine
>            Reporter: Gunnar Morling
>            Priority: Minor
>             Fix For: 4.2.0.CR1
>
>
> The two methods ValidatorImpl#shouldFailFast() and ValidationContext#shouldFailFast() seem redundant, one should be removed IMO (see https://github.com/hibernate/hibernate-validator/pull/25/files#r1349). In case we actually need both methods this issue can be closed without further actions.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the hibernate-issues mailing list