[hibernate-issues] [Hibernate-JIRA] Commented: (HSEARCH-5) Only index an entity when it's index properties have physically changed

[Sanne Grinovero (JIRA)]

    [ http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39468#action_39468 ] 

Sanne Grinovero commented on HSEARCH-5:
---------------------------------------

Hi Stephane,
amazing that there has been a patch 2 years for this, I wish we had more time to discuss this earlier.
But to eventually merge this some things should still be polished:
1)Patch should be updated to current code base.
2)as mentioned above, we should discuss how safe the "hash" actually is.
3)Having to rely on the index state during a write doesn't seem a good idea anyway: I'm afraid this works only on non-clustered non-async backends. If you use an async backend or the JMS backend, you might be taking a decision during DocumentBuild according to outdated state, we could hardly claim this is still having some transactional semantics.
4)People might not be happy to waste more space in the index, nor extracting a stored field is very efficient in Lucene. So it might be more efficient in some cases, but it should be optional as I think in some cases it would not be faster than a plain update.

Main difference with HSEARCH-361 is that this one attempts to skip unneeded index writes, while HSEARCH-361 focuses on avoiding lazyloading of the missing graph needed to rebuild all fields; as consequence likely also prevent unneeded writes.

> Only index an entity when it's index properties have physically changed
> -----------------------------------------------------------------------
>
>                 Key: HSEARCH-5
>                 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-5
>             Project: Hibernate Search
>          Issue Type: New Feature
>          Components: engine
>            Reporter: Emmanuel Bernard
>            Priority: Minor
>         Attachments: hibernate-search-3.0.1.GA-hashing_patch.diff, hibernate-search-3.0.1.GA-id_field_patch.diff
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira